Skip to content

NO-JIRA: SDK post-publish tasks #15942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
logonoff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: SDK post-publish tasks #15942

logonoff wants to merge 1 commit into from
+6 −8

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Jan 21, 2026 •
edited by coderabbitai bot
Loading

  • Forgot to remove console-plugin-shared from docs, add removal of this package to 4.22 notes
  • Remove upgrade-PatternFly.md

Summary by CodeRabbit

  • Documentation
    • Deprecated the @openshift-console/plugin-shared package. Plugins should remove this dependency from their package.json.
    • Updated and removed related documentation reflecting the package deprecation.

✏️ Tip: You can customize this high-level summary in your review settings.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 21, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2026

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

  • Forgot to remove console-plugin-shared from docs, add removal of this package to 4.22 notes
  • Remove upgrade-PatternFly.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and rhamilto January 21, 2026 20:11
@openshift-ci openshift-ci bot added the component/sdk Related to console-plugin-sdk label Jan 21, 2026
@logonoff
Copy link
Member Author

logonoff commented Jan 21, 2026

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 21, 2026
@logonoff
Copy link
Member Author

logonoff commented Jan 21, 2026

/label docs-approved
/verified bypass

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 21, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

This pull request removes the @openshift-console/plugin-shared package and related documentation from the Console codebase. Changes include: deleting references to the package from README files across the project, removing the upgrade-PatternFly.md file and its docFiles mapping, and adding a release notes entry documenting the deprecation. The npm package is marked as deprecated, and plugins are advised to remove the dependency from their package.json. All modifications are documentation and configuration-related with no code logic changes.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'NO-JIRA: SDK post-publish tasks' is vague and generic, using non-descriptive language that doesn't convey the specific changes made—removing console-plugin-shared and upgrade-PatternFly.md. Provide a more descriptive title that clearly indicates the main changes, such as 'Remove console-plugin-shared and upgrade-PatternFly.md' or 'SDK cleanup: deprecate plugin-shared and remove PatternFly upgrade guide'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 21, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2026

@logonoff: The verified label has been added.

Details

In response to this:

/label docs-approved
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Jan 21, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026
@jhadvig
Copy link
Member

jhadvig commented Jan 23, 2026

/override ci/prow/e2e-gcp-console
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-console

Details

In response to this:

/override ci/prow/e2e-gcp-console
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

1 more reviewer

@vojtechszocs vojtechszocs vojtechszocs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vojtechszocs vojtechszocs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@logonoff @openshift-ci-robot @vojtechszocs @jhadvig